Sublime Forum

EJS highlight?

#1

On Update build 3013 my ejs file suddenly change and the highlight are not as they where before ?

how to fix this ?

Pasted image778Ă—498 9.46 KB

1 Like
#2

When the status bar is showing and you open the file what text appears at the far right edge of the status bar?

0 Likes
#3

I have a similar case. The syntax detection is correct, but the highlight is not.

0 Likes
#5

You can change “<% %>” to “<!- -{ }–>”

0 Likes
#6

Here’s a bit more detailed example using the latest Sublime Text dev build (3107)

Screenshot from 2016-03-02 09:29:31.png1225Ă—831 129 KB


@yutent, what do you mean by: [quote="yutent, post:5, topic:17687, full:true"] You can change "<% %>" to "<!- -{ }-->" [/quote] "" is not an available option for me, and nevertheless the syntax used is valid ejs.
0 Likes
#7

So……I have no way, aha!
I like “<!- -{ }–>”.

Pasted image812Ă—449 37.9 KB

0 Likes
#8

I’ve forked the EJS package that’s in PackageControl and I’ve added a .sublime-syntax file to it.

I need to write some tests and add some EJS specific key words for highlighting. But, this gets you proper HTML and almost proper JS highlighting, just no specific EJS keywords such as “include” highlighting.

2 Likes
#9

Yep! That does the job spectacularly. Good job! :slightly_smiling:

0 Likes
#10

The main issue I’ve noticed (aside from needing EJS specific keywords) is that on line 11 those braces are scoped as illegal due to popping in and out of the JS scope the starting braces aren’t matched up with them.

Not sure how to go about fixing that since I’m really just including the HTML and JS syntax files from core to do the scoping.

Maybe @wbond has some insight?

I’m thinking I may have to just add little “patch” matches to override the scoping applied… but hoping there’s something a bit more clever that can be done.

0 Likes
#11

In the EJS syntax add match clauses for ) and }. Then include JavaScript after them. This should be sufficient since they should only ever occur in the top-most context due to the fact that there won’t be any code that will have taken the lexer into one of the nested contexts.

0 Likes
#12

Thanks for input! but… not sure I quite follow on that. As it stands, they’re getting scoped in JS but as:

<% }) %>
   ^ text.html.ejs source.js.embedded.ejs
    ^ text.html.ejs source.js.embedded.ejs invalid.illegal.stray.brace.round.js

and any other matching i try to do with those, breaks the HTML highlighting :confused:

0 Likes
#13

I added a comment at https://github.com/subhaze/EJS.tmLanguage/commit/e3bb21f08ae4a7453da6b6e950bd6111199f1cdd#commitcomment-16486307

1 Like