It's important to distinguish between selections, find, and search. The change I was looking to make in https://github.com/braver/Solarized/pull/58 is specific to progressively enhance search.
The difference between find and search is that find is built in to ST. So you use global settings in the color schemes i.e.
findHighlightForeground. These have limitations. Besides, when a plugin provides any kind of search feature it can't piggyback off those settings, that is to say, you can't just apply those global settings to regions for custom search highlighting. Ideally you actually do want to use those settings for search, or at least have your search highlighting look the same as ST's find feature.
So what does Solarized Color Scheme look like in 3147?
Selections in Solarized Color Scheme in Sublime Text:
This what selections in Vim look like (Solarized8 in Vim (an optimized up to date version of the official solarized)):
I think these selections in Vim look tons better than the selections in Sublime Text.
Find i.e. ctrl+f (Sublime Text):
Search with NeoVintageous (Sublime Text):
Vim (find/search are the same in Vim):
I prefer Vim's selections and highlighting. The find highlighting in the ST Solarized Color Scheme in 3147 is good. I think it would be better as one of the colors from the standard solarized color palette i.e. yellow and orange for first /current matches (Vim):