BracketHighlighter2 BETA Branch

[facelessuser]

I will make the ruby post_match plugin official. If this works good for you.

[vitaLee]

Man, you’re tireless.
It’s working.
Im sure there’ll be other exotic problems to solve with ruby being expressive as it’s, but you clearly prooved the flexibility of BH2.

[vitaLee]

you might want to update open pattern to
[pre=#212121]“open”: “(^\s*\b(?:if|until|unless|while|begin|class|module|def\b\s*[a-zA-Z_]+)|do)\b”[/pre]
to account for this side effect

Also i vote 1+ for styles extracted and reused across definitions.

[facelessuser]

[quote=“vitaLee”]you might want to update open pattern to
[pre=#212121]“open”: “(^\s*\b(?:if|until|unless|while|begin|class|module|def\b\s*[a-zA-Z_]+)|do)\b”[/pre]
to account for this side effect
[attachment=0]Screen shot 2012-10-23 at 22.42.21.png[/attachment]
[/quote]

Great! Thanks for your help on this. I haven’t coded in ruby so it is nice to have help nailing it down.

[quote=“vitaLee”]
Also i vote 1+ for styles extracted and reused across definitions.[/quote]

That is the good thing about this being an alpha; in an alpha I can change everything and say “I told it you it was an alpha”. Beta I don’t have that much flexibility. I am thinking it would make more sense with separate style objects. I will have to see how much I have to change in the algorithm to make that happen. I will see if anyone else chimes in as well.

[facelessuser]

Ruby fixes are in.

Still tinkering with the styles. Separating the styles doesn’t really reduce the number of style stuff by much, it just puts it in a separate place. The regions are made up of the whole combination of icon, color, and highlight style, so they really need to be one package. So even if you use the same color and highlight style, having different icons still means having separate style objects. And I really don’t think I am looking for an overly complicated styling system either. I will play with it in the next couple of days, and hopefully role something out. I think the separation is good, I just don’t think its going to amount to great reduction of stuff in the config file.

That is how it goes though; you want something highly configurable, sometimes the downside is you have to configure that stuff every time.

[iamntz]

I either found a small bug or i don’t get it right.
So, in my bh_wrapping file (inside user folder) i added this:

{ "enabled": true, "language_list": "HTML", "HTML 5", "XML", "PHP", "ColdFusion", "ColdFusionCFC"], "language_filter": "whitelist", "entries": {"name": "HTML/XML Tag", "brackets": "<${BH_SEL:NAME}>", "</${BH_SEL:NAME}>"]}, {"name": "HTML/XML Tag - Block", "brackets": "<${BH_SEL:NAME}>", "</${BH_SEL:NAME}>"], "insert_style": "block"}, {"name": "HTML/XML Tag - Block Indent", "brackets": "<${BH_SEL:NAME}>", "</${BH_SEL:NAME}>"], "insert_style": "indent_block"}, {"name": "PHP Tags", "brackets": "<?php${BH_SEL}", "?>"], "insert_style": "indent_block"}, {"name": "PHP Tags", "brackets": "<?php${BH_SEL}", "?>"], "insert_style": "block"} ] },

What i would like is to highlight pairs of <?php ?> tags. What do i do wrong?

Thanks!

[vitaLee]

bracket pair definitions are within bh_core.sublime-settings.
i imagine there’ll be conflicts with already defined pairs containing angle brackets though.

[facelessuser]

Nah, you should be able to define php no problem. I will post in a bit (if the forum lets me; I think it is breaking down again).

[facelessuser]

Just paste the php define before tags. Order counts in the settings file.

[pre=#2D2D2D] // PHP enclosure
{
“name”: “php_enclosure”,
“open”: “(<\?php)”,
“close”: “(\?>)”,
“icon”: “angle”,
“color”: “brackethighlighter.angle”,
“style”: “underline”,
“language_filter”: “whitelist”,
“scope_exclude”: “string”, “comment”, “keyword.operator”],
“language_list”: “HTML”, “HTML 5”, “XML”, “PHP”, “HTML+CFML”, “ColdFusion”, “ColdFusionCFC”],
“enabled”: true
},
// HTML Tags
{
“name”: “tag”,
“open”: “(<)”,
“close”: “(>)”,
“icon”: “tag”,
“color”: “brackethighlighter.tag”,
“style”: “outline”,
“language_filter”: “whitelist”,
“scope_exclude”: “string”, “comment”, “keyword.operator”],
“language_list”: “HTML”, “HTML 5”, “XML”, “PHP”, “HTML+CFML”, “ColdFusion”, “ColdFusionCFC”],
“plugin_library”: “bh_modules.tags”,
“enabled”: true
},[/pre]

[vitaLee]

@facelessuser is that a custom color scheme you’re using?
care to share?

[iamntz]

Man, you are awesome! Thanks a lot, now looks beautiful!

Btw, there is a way we can reward you for the awesome job you do? A paypal account maybe?

[facelessuser]

[quote=“iamntz”]Man, you are awesome! Thanks a lot, now looks beautiful!

Btw, there is a way we can reward you for the awesome job you do? A paypal account maybe? [/quote]

Yeah, when you click it, it references a different project, but you can go here.

https://www.paypal.com/en_US/i/btn/btn_donateCC_LG.gif

[quote=“vitaLee”]@facelessuser is that a custom color scheme you’re using?
care to share?[/quote]

Sure, it is a modified Tomorrow-Night-Eighties theme.

Here is the gist gist.github.com/3946761.

It isn’t perfect yet. Tomorrow-Night by default highlights some things I don’t want it to in some languages, I have changed most of those cases though. Also, there is a number of personal scopes in there you can keep or remove. And one more thing, some things that you see mine highlight won’t highlight on yours because I use some modified languages that insert some special scopes for my theme to trigger off of, but in general, it should work fine for you.

[iamntz]

Found a small bug (i think).
So…

If the matching group consist in more than one char, like, let’s say <?php ?> thing and one it’s invalid, it should stop highlight when you focus it. Don’t know if this make sense, but try to look at the movie (i only moved left/right with arrow keys):

(http://img.iamntz.com/jing/2012-10-25_2114.swf)

//edit:
actually scratch that, me dumb!

[iamntz]

Ok, so, as i said, me dumb
I’m trying to make ST to also highlight if/endif foreach/endforeach and so on in php. What i have now (after like 50 different combinations or so) is this:

open": "(^if|foreach|while.+:$)", "close": "(^endif|endforeach|endwhile;$)",

But will not match correctly what i need (php have two ways of doing blocks; one is with if/endif and the other is with curly braces)

However, if i’ll do only this:

"open": "(^if.+:$)", "close": "(^endif;$)",

works good…ish. Because will make things red (which is an error) when i focus inside of the condition:

While things are peachy when i’m inside of the block:

What do i do wrong?

Thanks!

[facelessuser]

[quote=“iamntz”]Ok, so, as i said, me dumb
I’m trying to make ST to also highlight if/endif foreach/endforeach and so on in php. What i have now (after like 50 different combinations or so) is this:

open": "(^if|foreach|while.+:$)", "close": "(^endif|endforeach|endwhile;$)",

But will not match correctly what i need (php have two ways of doing blocks; one is with if/endif and the other is with curly braces)

However, if i’ll do only this:

"open": "(^if.+:$)", "close": "(^endif;$)",

works good…ish. Because will make things red (which is an error) when i focus inside of the condition:

While things are peachy when i’m inside of the block:

What do i do wrong?

Thanks![/quote]

You are doing nothing wrong. What you need is a bracket plugin that taps into the compare event. During that event, you would need to compare the values to help sort out which closing bracket goes with which opening bracket. Give me an hour or so and I will try and show you what I mean. You are diving into undocumented awesomeness.

[facelessuser]

Okay, I got to it quite a bit earlier…

Tweak this to your liking:
[pre=#2D2D2D] {
“name”: “php_keywords”,
“open”: “^\s*(if|foreach|while.+:$)”,
“close”: “^\s*(endif|endforeach|endwhile;$)”,
“icon”: “dot”,
“color”: “brackethighlighter.tag”,
“style”: “underline”,
“language_filter”: “whitelist”,
“scope_exclude”: “string”, “comment”],
“language_list”: “HTML”, “HTML 5”, “XML”, “PHP”, “HTML+CFML”, “ColdFusion”, “ColdFusionCFC”],
“plugin_library”: “User.phpkeywords”,
“enabled”: true
},[/pre]

Here is the awesome sauce…save as User/phpkeywords.py
[pre=#2D2D2D]def compare(name, first, second, bfr):
return “end” + bfrfirst.begin:first.end] == bfrsecond.begin:second.end][/pre]

Not so bad eh?

[vitaLee]

is it a default behaviour for Sublime to add icon in the gutter for each line of a multiline underlined (mouthful) region, or it’s something you control?
i found myself exploitinhg BH2 in attempt to match Obj-C @interface @implementation directives and noticed if i use style:underline for each line of the opening “bracket” there’s an icon in gutter, while the same is not true for outline, solid (icon only on first line).

[facelessuser]

Sorry, got a little careless:

[pre=#2D2D2D]def compare(name, first, second, bfr):
opening = bfrfirst.begin:first.end]
closing = bfrsecond.begin:second.end]
match = False
if opening.startswith(“while”):
if closing.startswith(“endwhile”):
match = True
else:
match = “end” + bfrfirst.begin:first.end] == bfrsecond.begin:second.end]
return match[/pre]

That should be better.

[facelessuser]

[quote=“vitaLee”]is it a default behaviour for Sublime to add icon in the gutter for each line of a multiline underlined (mouthful) region, or it’s something you control?
i found myself exploitinhg BH2 in attempt to match Obj-C @interface @implementation directives and noticed if i use style:underline for each line of the opening “bracket” there’s an icon in gutter, while the same is not true for outline, solid (icon only on first line).[/quote]

Underline is a trick. It isn’t like a normal region. There is no underline style really. There is an option in Sublime that says if a region is size 0, you can render it as an underline. So, to simulate an underline region, I take region X, Y and break it up into a series of zero size regions. So really an underline (y-x) regions, not one. That is why multi-line will show multiple icons. Because each underlined character is its own region.

[iamntz]

Thanks! Works… partially

because it also match if(){} expressions (and it shouldn’t)

what i came up is this pattern:

            "open": "^\\s*(if|foreach|while).*:$",
            "close": "^\\s*(endif|endforeach|endwhile;$)"

Thing is… while in regexbuddy works just fine, in editor it doesn’t. Most likely i do some escaping wrong. Any idea which is that? Thanks!

Btw, i noticed that if there is an error somewhere in the config file, the plugin stop to works until i restart ST. It’s a bug, a feature or a bit of both?