Hi, Jon. I have a few points;
First, I like the new panel. It seems more coherent to collapse them into one. I only ever used incremental search anyway. I also like the visual style of the outlines; it's nice to see what's coming. Is it possible to change the colours here? They are a little hard to see with my colour scheme and I'd like to highlight them a little more. The tmTheme files support a customisable 'selection' property, like this
Is there one for these 'pre-found' regions?
Second, I've got ctrl+i burned into my brain now, though, and it's the same mapping I use in Visual Studio, so I'm trying to re-establish the the old mappings. I'm almost there, but haven't found the perfect match yet. For those who want to copy, this seems to be working pretty well for me;
<binding key="ctrl+i" command="showPanel find"/>
<binding key="ctrl+i" command="findUnder">
<context name="isPanelVisible" value="true"/>
Only problem is the 'isPanelVisible' context seems a bit broad, and will work if you've got, say, the replace panel open. The context
<context name="option" value="isFindWidget"/>
Doesn't work as I expected, because when you do the find, the focus moves into the main window and I think the isFindWidget option is set to false; this means that hitting ctrl+i over and over does this;
find window/next match/find window/next match
find window/next match/next match/next match
Third, I'm guessing the find/replace panel is going to be updated to be incremental too? The ability to see what's going to get found/replaced would be really nice.
Lastly, (I promise,) is the question of what appears in the panel when you open it. The current behaviour seems to be to fill it with the current selection. I don't know if it's always been like that, but thinking about it now I wonder if it might be nicer to leave it with whatever it had in there last time. It's worth noting that when I have a regex in the box (say, 'l...') and that happens to have selected the word 'like', when I re-open the panel it is now searching for the literal 'like' and not my original pattern 'l...'. This can destroy possibly hard-crafted patterns, so I'd prefer that panel to keep whatever content it had before.
That'll teach you to ask for feedback.